Message-ID: <428225E7.4070605@freenet.de>
Date: Wed, 11 May 2005 17:33:59 +0200
From: Carsten Otte <cotte@freenet.de>
User-Agent: Debian Thunderbird 1.0.2 (X11/20050331)
MIME-Version: 1.0
To: Christoph Hellwig <hch@infradead.org>
CC: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
       schwidefsky@de.ibm.com, akpm@osdl.org
Subject: Re: [RFC/PATCH 2/5] mm/fs: add execute in place support
References: <428216F7.30303@de.ibm.com> <20050511150924.GA29976@infradead.org>
In-Reply-To: <20050511150924.GA29976@infradead.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 884
Lines: 21

Christoph Hellwig wrote:

> This is a lot of code for a very special case.
>
>Could you try to put all the xip code into a separate file, e.g. mm/xip.c
>that's only built when CONFIG_XIP is set?  It would probably require
>duplicating a little more code if you want clean interfaces, e.g. probably
>a separate set of generic operations.
>
>  
>
Indeed that seems reasonable. There is no exact reason to have
this built into a kernel on a platform that does not have a bdev
for this. On the other hand, I believe the code should stay in
filemap.c, because it fits there conceptually. And I personally
dislike #ifdef in the middle of a file.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/