Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261937AbVELNgg (ORCPT ); Thu, 12 May 2005 09:36:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261950AbVELNgf (ORCPT ); Thu, 12 May 2005 09:36:35 -0400 Received: from [195.23.16.24] ([195.23.16.24]:45958 "EHLO bipbip.comserver-pie.com") by vger.kernel.org with ESMTP id S261937AbVELNgd (ORCPT ); Thu, 12 May 2005 09:36:33 -0400 Message-ID: <42835BDB.40505@grupopie.com> Date: Thu, 12 May 2005 14:36:27 +0100 From: Paulo Marques Organization: Grupo PIE User-Agent: Mozilla Thunderbird 1.0 (X11/20041206) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Paulo Marques Cc: Adrian Bunk , Jesper Juhl , Andrew Morton , davem@davemloft.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] kernel/module.c has something to hide. (whitespace cleanup) References: <20050510161657.3afb21ff.akpm@osdl.org> <20050510.161907.116353193.davem@davemloft.net> <20050510170246.5be58840.akpm@osdl.org> <20050510.170946.10291902.davem@davemloft.net> <20050510172913.2d47a4d4.akpm@osdl.org> <4281E78B.2030103@grupopie.com> <20050511225657.GM6884@stusta.de> <42834935.9060404@grupopie.com> In-Reply-To: <42834935.9060404@grupopie.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1379 Lines: 41 Paulo Marques wrote: > Adrian Bunk wrote: > >> On Wed, May 11, 2005 at 12:07:55PM +0100, Paulo Marques wrote: >> [...] >> >>> Just a small sugestion: do a sha (or md5sum, or whatever hash >>> function you prefer) to vmlinux before and after applying the patches. >>> >>> If all is well, it shouldn't change (since this is just whitespace >>> cleanup), and it is a little more robust than just checking the size. >> >> That's wrong. >> >> vmlinux contains the date of the compilation. > > You're right, I forgot about that... > > Removing UTS_VERSION from init/version.c would make this work, or are > there other places where this might be a problem? Ok, I've just tested this. At least with my config, if I remove both instances of UTS_VERSION from init/version.c, the resulting vmlinux files are exactly identical with the same sha1sum. So maybe Jesper can use this to make *really* sure that there are no actual changes with the patches, just whitespace changes. -- Paulo Marques - www.grupopie.com An expert is a person who has made all the mistakes that can be made in a very narrow field. Niels Bohr (1885 - 1962) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/