Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262320AbVEMJLF (ORCPT ); Fri, 13 May 2005 05:11:05 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262318AbVEMJLF (ORCPT ); Fri, 13 May 2005 05:11:05 -0400 Received: from rev.193.226.232.93.euroweb.hu ([193.226.232.93]:37390 "EHLO dorka.pomaz.szeredi.hu") by vger.kernel.org with ESMTP id S262317AbVEMJK4 (ORCPT ); Fri, 13 May 2005 05:10:56 -0400 To: linuxram@us.ibm.com CC: jamie@shareable.org, ericvh@gmail.com, 7eggert@gmx.de, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, smfrench@austin.rr.com, hch@infradead.org In-reply-to: <1115974780.6248.346.camel@localhost> (message from Ram on Fri, 13 May 2005 01:59:40 -0700) Subject: Re: [RCF] [PATCH] unprivileged mount/umount References: <20050511170700.GC2141@mail.shareable.org> <1115840139.6248.181.camel@localhost> <20050511212810.GD5093@mail.shareable.org> <1115851333.6248.225.camel@localhost> <20050512010215.GB8457@mail.shareable.org> <20050512064514.GA12315@mail.shareable.org> <20050512151631.GA16310@mail.shareable.org> <1115946620.6248.299.camel@localhost> <1115969123.6248.336.camel@localhost> <1115974780.6248.346.camel@localhost> Message-Id: From: Miklos Szeredi Date: Fri, 13 May 2005 11:10:36 +0200 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1192 Lines: 35 > dentry = file->f_dentry; > mnt = file->f_vfsmnt; > inode = dentry->d_inode; > + if(mnt->mnt_namespace != current->namespace) > + goto out_putf; > > error = -ENOTDIR; > if (!S_ISDIR(inode->i_mode)) > Does this actually fix the problem? The open is done in the right namespace, and mount() doesn't call open(). I think the right fix is something like this: Index: linux/fs/namespace.c =================================================================== --- linux.orig/fs/namespace.c 2005-05-13 11:03:50.000000000 +0200 +++ linux/fs/namespace.c 2005-05-13 11:05:06.000000000 +0200 @@ -160,7 +160,7 @@ clone_mnt(struct vfsmount *old, struct d mnt->mnt_root = dget(root); mnt->mnt_mountpoint = mnt->mnt_root; mnt->mnt_parent = mnt; - mnt->mnt_namespace = old->mnt_namespace; + mnt->mnt_namespace = current->namespace; /* stick the duplicate mount on the same expiry list * as the original if that was on one */ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/