Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262414AbVEMQFn (ORCPT ); Fri, 13 May 2005 12:05:43 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262415AbVEMQFm (ORCPT ); Fri, 13 May 2005 12:05:42 -0400 Received: from mail.kroah.org ([69.55.234.183]:61625 "EHLO perch.kroah.org") by vger.kernel.org with ESMTP id S262414AbVEMQFX (ORCPT ); Fri, 13 May 2005 12:05:23 -0400 Date: Fri, 13 May 2005 09:02:30 -0700 From: Greg KH To: Michael Tokarev Cc: linux-hotplug-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [ANNOUNCE] hotplug-ng 002 release Message-ID: <20050513160230.GB11010@kroah.com> References: <20050506212227.GA24066@kroah.com> <20050509211323.GB5297@tsiryulnik> <20050512214229.GA30233@kroah.com> <42846310.1000807@tls.msk.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <42846310.1000807@tls.msk.ru> User-Agent: Mutt/1.5.8i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1656 Lines: 40 On Fri, May 13, 2005 at 12:19:28PM +0400, Michael Tokarev wrote: > Greg KH wrote: > [] > > Subject: PCI: add MODALIAS to hotplug event for pci devices > > --- gregkh-2.6.orig/drivers/pci/hotplug.c 2005-05-12 14:28:39.000000000 -0700 > > +++ gregkh-2.6/drivers/pci/hotplug.c 2005-05-12 14:28:47.000000000 -0700 > > @@ -52,6 +52,16 @@ > > if ((buffer_size - length <= 0) || (i >= num_envp)) > > return -ENOMEM; > > > > + envp[i++] = scratch; > > + length += scnprintf (scratch, buffer_size - length, > > + "MODALIAS=pci:v%08Xd%08Xsv%08Xsd%08Xbc%02Xsc%02Xi%02x\n", > [] > > Subject: PCI: add modalias sysfs file for pci devices > > --- gregkh-2.6.orig/drivers/pci/pci-sysfs.c 2005-05-12 14:28:25.000000000 -0700 > > +++ gregkh-2.6/drivers/pci/pci-sysfs.c 2005-05-12 14:28:40.000000000 -0700 > > + return sprintf(buf, "pci:v%08Xd%08Xsv%08Xsd%08Xbc%02Xsc%02Xi%02x\n", > > + pci_dev->vendor, pci_dev->device, > > + pci_dev->subsystem_vendor, pci_dev->subsystem_device, > > + (u8)(pci_dev->class >> 16), (u8)(pci_dev->class >> 8), > > Just a small note/suggestion... Looks like it's worth to create a common > routine for the two cases. Just to be sure the value in $MODALIAS and in > devices/xx/modalias are the same. I think. Sure, if you want to do so go ahead :) But be careful of the CONFIG_HOTPLUG issue... It's easier just to leave it as is for now. thanks, greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/