Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261563AbVEPNnu (ORCPT ); Mon, 16 May 2005 09:43:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261564AbVEPNnu (ORCPT ); Mon, 16 May 2005 09:43:50 -0400 Received: from mail.tv-sign.ru ([213.234.233.51]:64703 "EHLO several.ru") by vger.kernel.org with ESMTP id S261563AbVEPNnt (ORCPT ); Mon, 16 May 2005 09:43:49 -0400 Message-ID: <4288A55B.10F7240E@tv-sign.ru> Date: Mon, 16 May 2005 17:51:23 +0400 From: Oleg Nesterov X-Mailer: Mozilla 4.76 [en] (X11; U; Linux 2.2.20 i686) X-Accept-Language: en MIME-Version: 1.0 To: Nick Piggin Cc: linux-kernel@vger.kernel.org Subject: Re: [patch] improve SMP reschedule and idle routines Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 554 Lines: 20 Nick Piggin wrote: > > void default_idle(void) > { > + local_irq_enable(); > + Stupid question. Why is this sti() needed? Interrupts are enabled in start_secondary() before cpu_idle() call, and they can't be disabled after return from schedule(). The same question applies to poll_idle/mwait_idle. Oleg. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/