Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261910AbVEPVmG (ORCPT ); Mon, 16 May 2005 17:42:06 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261929AbVEPVmF (ORCPT ); Mon, 16 May 2005 17:42:05 -0400 Received: from mail.kroah.org ([69.55.234.183]:22948 "EHLO perch.kroah.org") by vger.kernel.org with ESMTP id S261910AbVEPVkD (ORCPT ); Mon, 16 May 2005 17:40:03 -0400 Date: Mon, 16 May 2005 13:53:58 -0700 From: Greg KH To: Roland Dreier Cc: Arnd Bergmann , linuxppc64-dev@ozlabs.org, linux-kernel@vger.kernel.org, Paul Mackerras , Anton Blanchard , Benjamin Herrenschmidt Subject: Re: [PATCH 7/8] ppc64: SPU file system Message-ID: <20050516205358.GA11938@kroah.com> References: <200505132117.37461.arnd@arndb.de> <200505132129.07603.arnd@arndb.de> <20050514074524.GC20021@kroah.com> <528y2flygt.fsf@topspin.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <528y2flygt.fsf@topspin.com> User-Agent: Mutt/1.5.8i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 719 Lines: 18 On Mon, May 16, 2005 at 01:14:58PM -0700, Roland Dreier wrote: > Greg> No, as Ben said, do not do this. Use write. And as you are > Greg> only doing 1 type of ioctl, it shouldn't be an issue. Also > Greg> it will be faster than the ioctl due to lack of BKL usage :) > > This is no longer true. ioctls don't have to take the BKL now that > struct file_operations has unlocked_ioctl and compat_ioctl. Yes, but his patch did not use them :) thanks, greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/