Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261915AbVEPVyO (ORCPT ); Mon, 16 May 2005 17:54:14 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261901AbVEPVwE (ORCPT ); Mon, 16 May 2005 17:52:04 -0400 Received: from ezoffice.mandriva.com ([84.14.106.134]:40200 "EHLO ezoffice.mandriva.com") by vger.kernel.org with ESMTP id S261889AbVEPVmp (ORCPT ); Mon, 16 May 2005 17:42:45 -0400 To: Kernel Mailing List , ACPI Developers Cc: Yann Droneaud From: Yann Droneaud Subject: [PATCH 1/2] IPMI and acpi=off|ht : acpi-get-firmware-failure.patch In-Reply-To: References: Date: 16 May 2005 23:42:38 +0200 Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.4 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1420 Lines: 34 This patch check that rsdt_info->pointer is not NULL before trying to unmap ACPI tables, which can happen if acpi_tb_get_rsdt_address() failed. In my case, with ipmi_si_intf module and acpi=ht|off parameter, the call failed because acpi_gbl_table_flags is not initialised, so the address.pointer_type is not setup correctly, leading to message like: May 16 11:18:29 localhost kernel: ACPI-0166: *** Error: Invalid address flags 8 and rsdt_info->pointer equal to NULL leading to the Oops. --- linux-2.6.11.9/drivers/acpi/tables/tbxfroot.c 2005-05-11 18:42:39.000000000 -0400 +++ linux-2.6.11.9-fixes/drivers/acpi/tables/tbxfroot.c 2005-05-16 16:51:33.115768232 -0400 @@ -313,7 +313,9 @@ acpi_get_firmware_table ( cleanup: - acpi_os_unmap_memory (rsdt_info->pointer, (acpi_size) rsdt_info->pointer->length); + if (rsdt_info->pointer) { + acpi_os_unmap_memory (rsdt_info->pointer, (acpi_size) rsdt_info->pointer->length); + } ACPI_MEM_FREE (rsdt_info); if (header) { Signed-Off-by: ydroneaud@mandriva.com -- Yann Droneaud Consulting Engineer Professional Services Mandriva http://mandriva.com/ (previously known as Mandrakesoft) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/