Date: Tue, 17 May 2005 06:54:52 +0100
From: Al Viro <viro@parcelfarce.linux.theplanet.co.uk>
To: Greg K-H <greg@kroah.com>
Cc: linux-kernel@vger.kernel.org, petero2@telia.com
Subject: Re: [PATCH] Fix root hole in pktcdvd
Message-ID: <20050517055452.GQ1150@parcelfarce.linux.theplanet.co.uk>
References: <11163046681444@kroah.com> <11163046692974@kroah.com> <20050517050025.GP1150@parcelfarce.linux.theplanet.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20050517050025.GP1150@parcelfarce.linux.theplanet.co.uk>
User-Agent: Mutt/1.4.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 719
Lines: 14

On Tue, May 17, 2005 at 06:00:25AM +0100, Al Viro wrote:
> Same comment as for previous patch.  I'll take a look at that sucker,
> it might happen to be OK, seeing that most of the bdev ->ioctl() instances
> ignore file argument and we might get away with passing odd stuff to
> anything that could occur here.

Oh, lovely - pkt_open() opens underlying device, unless we already have our
device opened.  Guess what happens if you open() with O_RDONLY and
then - with O_RDWR?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/