Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261301AbVEQH0d (ORCPT ); Tue, 17 May 2005 03:26:33 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261305AbVEQH0d (ORCPT ); Tue, 17 May 2005 03:26:33 -0400 Received: from ozlabs.org ([203.10.76.45]:31934 "EHLO ozlabs.org") by vger.kernel.org with ESMTP id S261301AbVEQH03 (ORCPT ); Tue, 17 May 2005 03:26:29 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <17033.38609.60873.138572@cargo.ozlabs.ibm.com> Date: Tue, 17 May 2005 17:01:37 +1000 From: Paul Mackerras To: Arnd Bergmann Cc: linuxppc64-dev@ozlabs.org, linux-kernel@vger.kernel.org, Anton Blanchard , Benjamin Herrenschmidt Subject: Re: [PATCH 4/8] ppc64: add BPA platform type In-Reply-To: <200505132125.34358.arnd@arndb.de> References: <200505132117.37461.arnd@arndb.de> <200505132125.34358.arnd@arndb.de> X-Mailer: VM 7.19 under Emacs 21.4.1 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 823 Lines: 25 Arnd Bergmann writes: > This adds the basic support for running on BPA machines. > So far, this is only the IBM workstation, and it will > not run on others without a little more generalization. > +/* FIXME: consolidate this into rtas.c or similar */ > +static void __init pSeries_calibrate_decr(void) Shouldn't this be called bpa_calibrate_decr or something similar? > -#define PV_630 0x0040 > -#define PV_630p 0x0041 > +#define PV_630 0x0040 > +#define PV_630p 0x0041 Hmmm, I don't think your patch needs to clean up the whitespace here. Regards, Paul. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/