Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 8BIT
Subject: RE: [RFC][PATCH] timers fixes/improvements
Date: Tue, 17 May 2005 08:38:45 -0700
Message-ID: <468F3FDA28AA87429AD807992E22D07E054DA776@orsmsx408>
Thread-Topic: [RFC][PATCH] timers fixes/improvements
Thread-Index: AcVYDDCpjI3D+miGQMGvGytmaYDs8gC6TeKg
From: "Sy, Dely L" <dely.l.sy@intel.com>
To: "Greg KH" <greg@kroah.com>, "Christoph Lameter" <christoph@lameter.com>
Cc: "Oleg Nesterov" <oleg@tv-sign.ru>, "Andrew Morton" <akpm@osdl.org>,
       <linux-kernel@vger.kernel.org>, <mingo@elte.hu>,
       "Chen, Kenneth W" <kenneth.w.chen@intel.com>, <shai@scalex86.org>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 871
Lines: 31

On Friday, May 13, 2005 3:36 PM, Greg KH wrote:
> > The definition of GET_INDEX is suspect:
> > 
> > #define GET_INDEX(a, b) (((a - PCI_DEVICE_ID_INTEL_MCH_PA) << 3) +
b)
> > 
> > should this not be
> > 
> > #define GET_INDEX(a, b) ((((a) - PCI_DEVICE_ID_INTEL_MCH_PA) << 3) +
\
> > 				((b) & 7))
> > 
> > ?
>
> Dely, any thoughts about this, or know who would know about it?

Greg,

I looked at the code and talked with Steve on this.  The fix is correct;
i.e. b has to be masked with 7.  Would Christoph or you send out a 
patch for the fix or would you like us to do so?  Thanks for finding out

the problem.

Thanks,
Dely
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/