Date: Tue, 17 May 2005 08:50:55 -0700
From: Greg KH <greg@kroah.com>
To: "Sy, Dely L" <dely.l.sy@intel.com>
Cc: Christoph Lameter <christoph@lameter.com>, Oleg Nesterov <oleg@tv-sign.ru>,
       Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org,
       mingo@elte.hu, "Chen, Kenneth W" <kenneth.w.chen@intel.com>,
       shai@scalex86.org
Subject: Re: [RFC][PATCH] timers fixes/improvements
Message-ID: <20050517155054.GA23640@kroah.com>
References: <468F3FDA28AA87429AD807992E22D07E054DA776@orsmsx408>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <468F3FDA28AA87429AD807992E22D07E054DA776@orsmsx408>
User-Agent: Mutt/1.5.8i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1066
Lines: 35

On Tue, May 17, 2005 at 08:38:45AM -0700, Sy, Dely L wrote:
> On Friday, May 13, 2005 3:36 PM, Greg KH wrote:
> > > The definition of GET_INDEX is suspect:
> > > 
> > > #define GET_INDEX(a, b) (((a - PCI_DEVICE_ID_INTEL_MCH_PA) << 3) +
> b)
> > > 
> > > should this not be
> > > 
> > > #define GET_INDEX(a, b) ((((a) - PCI_DEVICE_ID_INTEL_MCH_PA) << 3) +
> \
> > > 				((b) & 7))
> > > 
> > > ?
> >
> > Dely, any thoughts about this, or know who would know about it?
> 
> Greg,
> 
> I looked at the code and talked with Steve on this.  The fix is correct;
> i.e. b has to be masked with 7.  Would Christoph or you send out a 
> patch for the fix or would you like us to do so?  Thanks for finding out
> the problem.

If you would send me a patch (or someone), that I could apply, I would
appreciate it.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/