Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261975AbVEQWEr (ORCPT ); Tue, 17 May 2005 18:04:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261953AbVEQWDJ (ORCPT ); Tue, 17 May 2005 18:03:09 -0400 Received: from mx1.redhat.com ([66.187.233.31]:4737 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S262008AbVEQVvu (ORCPT ); Tue, 17 May 2005 17:51:50 -0400 Date: Tue, 17 May 2005 14:51:37 -0700 From: Pete Zaitcev To: =?UTF-8?B?UG96c8OhciBCYWzDoXpz?= Cc: bzolnier@elka.pw.edu.pl, linux-kernel@vger.kernel.org, zaitcev@redhat.com Subject: Re: Oops on CF removal and "convert device drivers to driver-model" Message-Id: <20050517145137.6b91f242.zaitcev@redhat.com> In-Reply-To: <20050517211704.GB7452@ojjektum.uhulinux.hu> References: <20050514135019.0b3252f1.zaitcev@redhat.com> <20050517211704.GB7452@ojjektum.uhulinux.hu> Organization: Red Hat, Inc. X-Mailer: Sylpheed version 1.9.9 (GTK+ 2.6.4; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 979 Lines: 27 On Tue, 17 May 2005 23:17:04 +0200, Pozsár Balázs wrote: > On Sat, May 14, 2005 at 01:50:19PM -0700, Pete Zaitcev wrote: > > @@ -1138,7 +1133,8 @@ static int idescsi_attach(ide_drive_t *d > > idescsi->host = host; > > idescsi->disk = g; > > g->private_data = &idescsi->driver; > > - err = ide_register_subdriver(drive, &idescsi_driver); > > + ide_register_subdriver(drive, &idescsi_driver); > > + err = 0; > > if (!err) { > > idescsi_setup (drive, idescsi); > > g->fops = &idescsi_ops; > > !err cannot be true here, so this seems buggy. Indeed. Unfortunately, Andrew's scripts notified me that he added the patch to his tree, so I'd need to wait for a turnaround before a fix-over-fix. -- Pete - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/