Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262025AbVEQXwq (ORCPT ); Tue, 17 May 2005 19:52:46 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261748AbVEQXuh (ORCPT ); Tue, 17 May 2005 19:50:37 -0400 Received: from graphe.net ([209.204.138.32]:46603 "EHLO graphe.net") by vger.kernel.org with ESMTP id S262025AbVEQXtn (ORCPT ); Tue, 17 May 2005 19:49:43 -0400 Date: Tue, 17 May 2005 16:49:23 -0700 (PDT) From: Christoph Lameter X-X-Sender: christoph@graphe.net To: Matthew Dobson cc: Dave Hansen , "Martin J. Bligh" , Jesse Barnes , Christoph Lameter , Andy Whitcroft , Andrew Morton , linux-mm , Linux Kernel Mailing List , shai@scalex86.org, steiner@sgi.com Subject: Re: NUMA aware slab allocator V3 In-Reply-To: <428A800D.8050902@us.ibm.com> Message-ID: References: <714210000.1116266915@flay> <200505161410.43382.jbarnes@virtuousgeek.org> <740100000.1116278461@flay> <1116289613.26955.14.camel@localhost> <428A800D.8050902@us.ibm.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Spam-Score: -5.9 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 896 Lines: 20 On Tue, 17 May 2005, Matthew Dobson wrote: > You're right, Dave. The series of #defines at the top resolve to the same > thing as numa_node_id(). Adding the above #defines will serve only to > obfuscate the code. Ok. > Another thing that will really help, Christoph, would be replacing all your > open-coded for (i = 0; i < MAX_NUMNODES/NR_CPUS; i++) loops. We have > macros that make that all nice and clean and (should?) do the right thing > for various combinations of SMP/DISCONTIG/NUMA/etc. Use those and if they > DON'T do the right thing, please let me know and we'll fix them ASAP. Some of that was already done but I can check again. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/