Subject: Re: CONFIG_KALLSYMS_EXTRA_PASS
From: Steven Rostedt <rostedt@goodmis.org>
To: pmarques@grupopie.com
Cc: linux-kernel@vger.kernel.org
In-Reply-To: <1116372428.428a7dccec930@webmail.grupopie.com>
References: <1116365006.9737.42.camel@localhost.localdomain>
	 <1116372428.428a7dccec930@webmail.grupopie.com>
Content-Type: text/plain
Organization: Kihon Technologies
Date: Tue, 17 May 2005 20:00:51 -0400
Message-Id: <1116374451.9737.47.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1280
Lines: 35

On Wed, 2005-05-18 at 00:27 +0100, pmarques@grupopie.com wrote:

> You can try the very crude (but effective) way to check if this is your problem
> or not. Go to scripts/kallsyms.c and change:
> 
> #define WORKING_SET             1024
> 
> to:
> 
> #define WORKING_SET             65536
> 

Yep, that did the trick. Thanks.  And just to make sure, I put it back
to 1024, recompiled, and got the error again.

> This will force kallsyms to use *all* the symbols for the compression, and the
> size of the result won't be affected by the symbol positions.
> 
> Don't forget to turn off KALLSYMS_EXTRA_PASS to test this.
> 
> If this turns out to be the problem _again_, I'll post a patch to fix this for
> good by storing the token data from the first pass and use it on the second
> pass. This will not only speed up compression, it will also guarantee that this
> kind of problems will never bite us again.

Your patch sounds too good to not be included even if this wasn't the
case. How come it hasn't been applied before?

-- Steve

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/