Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262043AbVERBI1 (ORCPT ); Tue, 17 May 2005 21:08:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262045AbVERBI0 (ORCPT ); Tue, 17 May 2005 21:08:26 -0400 Received: from omx2-ext.sgi.com ([192.48.171.19]:42902 "EHLO omx2.sgi.com") by vger.kernel.org with ESMTP id S262043AbVERBIU (ORCPT ); Tue, 17 May 2005 21:08:20 -0400 Date: Tue, 17 May 2005 18:07:42 -0700 (PDT) From: Christoph Lameter To: Matthew Dobson cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, shai@scalex86.org Subject: Re: NUMA aware slab allocator V2 In-Reply-To: <428A7E48.6060909@us.ibm.com> Message-ID: References: <20050512000444.641f44a9.akpm@osdl.org> <20050513000648.7d341710.akpm@osdl.org> <428A7E48.6060909@us.ibm.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 689 Lines: 17 On Tue, 17 May 2005, Matthew Dobson wrote: > Also, there is a similar loop for CPUs which should be replaced with > for_each_online_cpu(i). > > These for_each_FOO macros are cleaner and less likely to break in the > future, since we can simply modify the one definition if the way to > itterate over nodes/cpus changes, rather than auditing 100 open coded > implementations and trying to determine the intent of the loop's author. Ok. Done. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/