Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262046AbVERCEo (ORCPT ); Tue, 17 May 2005 22:04:44 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262048AbVERCEo (ORCPT ); Tue, 17 May 2005 22:04:44 -0400 Received: from fire.osdl.org ([65.172.181.4]:32643 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S262046AbVERCEl (ORCPT ); Tue, 17 May 2005 22:04:41 -0400 Date: Tue, 17 May 2005 19:03:43 -0700 From: Andrew Morton To: Christoph Lameter Cc: linux-kernel@vger.kernel.org, netdev@oss.sgi.com Subject: Re: [PATCH] NUMA aware allocation of transmit and receive buffers for e1000 Message-Id: <20050517190343.2e57fdd7.akpm@osdl.org> In-Reply-To: References: X-Mailer: Sylpheed version 1.0.0 (GTK+ 1.2.10; i386-vine-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 569 Lines: 16 Christoph Lameter wrote: > > NUMA awareness for the e1000 driver. Allocate transmit and receive buffers > on the node of the device. Hast thou any benchmarking results? > - txdr->buffer_info = vmalloc(size); > + txdr->buffer_info = kmalloc_node(size, GFP_KERNEL, node); How come this is safe to do? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/