Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262309AbVERPoc (ORCPT ); Wed, 18 May 2005 11:44:32 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262284AbVERPlg (ORCPT ); Wed, 18 May 2005 11:41:36 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:46055 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S262293AbVERPhn (ORCPT ); Wed, 18 May 2005 11:37:43 -0400 Date: Wed, 18 May 2005 16:37:39 +0100 From: Christoph Hellwig To: Carsten Otte Cc: Christoph Hellwig , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, schwidefsky@de.ibm.com, akpm@osdl.org Subject: Re: [RFC/PATCH 1/5] bdev: execute in place (V2) Message-ID: <20050518153739.GA25420@infradead.org> Mail-Followup-To: Christoph Hellwig , Carsten Otte , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, schwidefsky@de.ibm.com, akpm@osdl.org References: <1116422644.2202.1.camel@cotte.boeblingen.de.ibm.com> <1116424403.2202.16.camel@cotte.boeblingen.de.ibm.com> <20050518142739.GB23162@infradead.org> <428B6111.3000802@freenet.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <428B6111.3000802@freenet.de> User-Agent: Mutt/1.4.1i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 877 Lines: 25 On Wed, May 18, 2005 at 05:36:49PM +0200, Carsten Otte wrote: > Christoph Hellwig wrote: > > >>+ int (*direct_access) (struct inode *, sector_t, unsigned long *); > >> > >> > > > >this should have a block_device * first argument. > > > > > While I agree that (block_device *) would be a good thing to address > the target block device, the inode * is consistent with other > operations in this vector: open, release, & ioctl use the same scheme. That's going to change real soon. > The reason for inode * here is that the caller has no easy way to get > to the block_device *. How would the filesystem do that? sb->s_bdev - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/