Date: Wed, 18 May 2005 17:16:14 -0400 (EDT)
From: Rik van Riel <riel@redhat.com>
To: Arjan van de Ven <arjan@infradead.org>
cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] prevent NULL mmap in topdown model
In-Reply-To: <1116448683.6572.43.camel@laptopd505.fenrus.org>
Message-ID: <Pine.LNX.4.61.0505181714330.3645@chimarrao.boston.redhat.com>
References: <Pine.LNX.4.61.0505181556190.3645@chimarrao.boston.redhat.com>
 <1116448683.6572.43.camel@laptopd505.fenrus.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1228
Lines: 27

On Wed, 18 May 2005, Arjan van de Ven wrote:
> On Wed, 2005-05-18 at 15:57 -0400, Rik van Riel wrote:
> > This (trivial) patch prevents the topdown allocator from allocating
> > mmap areas all the way down to address zero.  It's not the prettiest
> > patch, so suggestions for improvement are welcome ;)
> 
> it looks like you stop at brk() time.. isn't it better to just stop just 
> above NULL instead?? Gives you more space and is less of an artificial 
> barrier..

Firstly, there isn't much below brk() at all.  Secondly, do we
really want to fill the randomized hole between the executable
and the brk area with data ?

Thirdly, we do want to continue detecting NULL pointer dereferences
inside large structs, ie. dereferencing an element 700kB into some
large struct...

-- 
"Debugging is twice as hard as writing the code in the first place.
Therefore, if you write the code as cleverly as possible, you are,
by definition, not smart enough to debug it." - Brian W. Kernighan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/