Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262405AbVERXmh (ORCPT ); Wed, 18 May 2005 19:42:37 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262411AbVERXmh (ORCPT ); Wed, 18 May 2005 19:42:37 -0400 Received: from one.firstfloor.org ([213.235.205.2]:18309 "EHLO one.firstfloor.org") by vger.kernel.org with ESMTP id S262405AbVERXm3 (ORCPT ); Wed, 18 May 2005 19:42:29 -0400 To: "Gilbert, John" Cc: Subject: Re: Illegal use of reserved word in system.h References: <2692A548B75777458914AC89297DD7DA08B0866F@bronze.dolby.net> From: Andi Kleen Date: Thu, 19 May 2005 01:42:28 +0200 In-Reply-To: <2692A548B75777458914AC89297DD7DA08B0866F@bronze.dolby.net> (John Gilbert's message of "Wed, 18 May 2005 12:07:29 -0700") Message-ID: User-Agent: Gnus/5.110002 (No Gnus v0.2) Emacs/21.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 936 Lines: 26 "Gilbert, John" writes: > > I think it's been in there a while, but only really blows up when built > > under recent kernels. > > I agree, it's probably not the right way to go. It's quite dangerous. I suppose it uses this for atomic.h, but it means that a mysql compiled under a uniprocessor kernel (or rather with a autoconf.h of a uniprocessor kernel, it can even be SMP) will have subtle races when run on a SMP system because the atomic instructions will miss lock prefixes. Sounds like an open deathtrap to me. I would suggest changing MySQL to keep its own copies of atomic.h for the different architectures. Then they can drop the asm/system.h includes too. -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/