Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262449AbVESCZi (ORCPT ); Wed, 18 May 2005 22:25:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262452AbVESCZh (ORCPT ); Wed, 18 May 2005 22:25:37 -0400 Received: from mx1.redhat.com ([66.187.233.31]:61116 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S262451AbVESCZb (ORCPT ); Wed, 18 May 2005 22:25:31 -0400 Date: Wed, 18 May 2005 22:25:25 -0400 (EDT) From: Rik van Riel X-X-Sender: riel@chimarrao.boston.redhat.com To: Linus Torvalds cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] prevent NULL mmap in topdown model In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 727 Lines: 18 On Wed, 18 May 2005, Linus Torvalds wrote: > Why not just change the "addr >= len" test into "addr > len" and be done > with it? If you're fine with not catching dereferences of a struct member further than PAGE_SIZE into a struct when the struct pointer is NULL, sure ... -- "Debugging is twice as hard as writing the code in the first place. Therefore, if you write the code as cleverly as possible, you are, by definition, not smart enough to debug it." - Brian W. Kernighan - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/