Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261779AbVESK1I (ORCPT ); Thu, 19 May 2005 06:27:08 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261656AbVESK1I (ORCPT ); Thu, 19 May 2005 06:27:08 -0400 Received: from mail.dvmed.net ([216.237.124.58]:50352 "EHLO mail.dvmed.net") by vger.kernel.org with ESMTP id S261537AbVESK07 (ORCPT ); Thu, 19 May 2005 06:26:59 -0400 Message-ID: <428C69EA.6080001@pobox.com> Date: Thu, 19 May 2005 06:26:50 -0400 From: Jeff Garzik User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.6) Gecko/20050328 Fedora/1.7.6-1.2.5 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Daniel Phillips CC: Mark Fasheh , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, ocfs2-devel@oss.oracle.com, torvalds@osdl.org, akpm@osdl.org, wim.coekaerts@oracle.com, lmb@suse.de Subject: Re: [RFC] [PATCH] OCFS2 References: <20050518223303.GE1340@ca-server1.us.oracle.com> <200505190230.23624.phillips@istop.com> In-Reply-To: <200505190230.23624.phillips@istop.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 568 Lines: 17 Daniel Phillips wrote: > Zero terminated strings for lock names is bad taste. It generates a bunch of > useless strlen executions and you force an ascii namespace for no apparent > reason. Add a 9th parameter, namelen, to the lock call maybe? What's wrong with ascii strings? We call those 'UTF8' these days. Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/