Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261224AbVESTD0 (ORCPT ); Thu, 19 May 2005 15:03:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261223AbVESTD0 (ORCPT ); Thu, 19 May 2005 15:03:26 -0400 Received: from e32.co.us.ibm.com ([32.97.110.130]:23258 "EHLO e32.co.us.ibm.com") by vger.kernel.org with ESMTP id S261224AbVESTDV (ORCPT ); Thu, 19 May 2005 15:03:21 -0400 Message-ID: <428CE2EF.803@us.ibm.com> Date: Thu, 19 May 2005 12:03:11 -0700 From: Matthew Dobson User-Agent: Mozilla Thunderbird 1.0.2 (X11/20050404) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Christoph Lameter CC: Dave Hansen , "Martin J. Bligh" , Jesse Barnes , Andy Whitcroft , Andrew Morton , linux-mm , Linux Kernel Mailing List , shai@scalex86.org, steiner@sgi.com Subject: Re: NUMA aware slab allocator V3 References: <714210000.1116266915@flay> <200505161410.43382.jbarnes@virtuousgeek.org> <740100000.1116278461@flay> <1116289613.26955.14.camel@localhost> <428A800D.8050902@us.ibm.com> <428B7B16.10204@us.ibm.com> <428BB05B.6090704@us.ibm.com> In-Reply-To: X-Enigmail-Version: 0.90.2.0 X-Enigmail-Supports: pgp-inline, pgp-mime Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1380 Lines: 36 Christoph Lameter wrote: > On Wed, 18 May 2005, Christoph Lameter wrote: > >>Fixes to the slab allocator in 2.6.12-rc4-mm2 >>- Remove MAX_NUMNODES check >>- use for_each_node/cpu >>- Fix determination of INDEX_AC > > Rats! The whole thing with cpu online and node online is not as easy as I > thought. There may be bugs in V3 of the numa slab allocator > because offline cpus and offline are not properly handled. Maybe > that also contributed to the ppc64 issues. Running this test through the "wringer" (aka building/booting on one of our PPC64 boxen). I'll let you know if this fixes any problems. > The earlier patch fails if I boot an x86_64 NUMA kernel on a x86_64 single > processor system. > > Here is a revised patch. Would be good if someone could review my use > of online_cpu / online_node etc. Is there some way to bring cpus > online and offline to test if this really works? Seems that the code in > alloc_percpu is suspect even in the old allocator because it may have > to allocate memory for non present cpus. I'll look through and see what I can tell you, but I gotta run to a meeting now. :( -Matt - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/