Date: Fri, 20 May 2005 10:18:08 -0700
From: Tom Rini <trini@kernel.crashing.org>
To: Kay Sievers <kay.sievers@vrfy.org>
Cc: Andrew Morton <akpm@osdl.org>,
       Kernel Mailing List <linux-kernel@vger.kernel.org>,
       Greg KH <greg@kroah.com>
Subject: Re: [PATCH 2.6.12-rc4] Add EXPORT_SYMBOL for hotplug_path
Message-ID: <20050520171808.GM3771@smtp.west.cox.net>
References: <20050519164323.GK3771@smtp.west.cox.net> <1116573175.7647.4.camel@dhcp-188.off.vrfy.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1116573175.7647.4.camel@dhcp-188.off.vrfy.org>
User-Agent: Mutt/1.5.9i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1772
Lines: 44

On Fri, May 20, 2005 at 09:12:55AM +0200, Kay Sievers wrote:
> On Thu, 2005-05-19 at 09:43 -0700, Tom Rini wrote:
> > If CONFIG_INPUT is set as a module, it will not load as hotplug_path is
> > not a defined symbol.  Trivial fix is to EXPORT_SYMBOL hotplug_path.
> > 
> > Signed-off-by: Tom Rini <trini@kernel.crashing.org>
> > 
> > Index: lib/kobject_uevent.c
> > ===================================================================
> > --- c7d7a187a2125518e655dfeadffd38156239ffc3/lib/kobject_uevent.c  (mode:100644)
> > +++ uncommitted/lib/kobject_uevent.c  (mode:100644)
> > @@ -21,6 +21,7 @@
> >  #include <linux/string.h>
> >  #include <linux/kobject_uevent.h>
> >  #include <linux/kobject.h>
> > +#include <linux/module.h>
> >  #include <net/sock.h>
> >  
> >  #define BUFFER_SIZE	1024	/* buffer for the hotplug env */
> > @@ -178,6 +179,7 @@
> >  
> >  #ifdef CONFIG_HOTPLUG
> >  char hotplug_path[HOTPLUG_PATH_LEN] = "/sbin/hotplug";
> > +EXPORT_SYMBOL(hotplug_path);
> >  u64 hotplug_seqnum;
> >  static DEFINE_SPINLOCK(sequence_lock);
> 
> Please don't export it again. We're on the way to make it private.
> Nobody should ever have access to it outside of the driver core. The
> input layer event stuff is completely broken and we are already working
> on fixing this to use the driver core instead of calling /sbin/hotplug,
> which is completely nonsense these days.

So Greg said he's ACK this since the "make it private" stuff isn't done
yet.  Will this go in or no?

-- 
Tom Rini
http://gate.crashing.org/~trini/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/