Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261575AbVETUde (ORCPT ); Fri, 20 May 2005 16:33:34 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261578AbVETUdd (ORCPT ); Fri, 20 May 2005 16:33:33 -0400 Received: from mx1.redhat.com ([66.187.233.31]:11197 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S261575AbVETUdT (ORCPT ); Fri, 20 May 2005 16:33:19 -0400 Date: Fri, 20 May 2005 16:32:58 -0400 (EDT) From: James Morris X-X-Sender: jmorris@thoron.boston.redhat.com To: Reiner Sailer cc: Andrew Morton , Chris Wright , Emily Ratliff , Kent E Yoder , , , Tom Lendacky Subject: Re: [PATCH 1 of 4] ima: related TPM device driver interal kernel interface In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1230 Lines: 37 On Fri, 20 May 2005, Reiner Sailer wrote: > > Why are you using LSM for this? > > > > LSM should be used for comprehensive access control frameworks which > > significantly enhance or even replace existing Unix DAC security. > > I see LSM is framework for security. IMA is an architecture that > enforces access control in a different way than SELinux. IMA guarantees > that executable content is measured and accounted for before > it is loaded and can access (and possibly corrupt) system resources. LSM is an access control framework. Your (few) LSM hooks always return zero, and don't enforce access control at all. You even have a separate measurement hook for modules. I suggest implementing all of your code via distinct measurement hooks, so measurement becomes a distinct and well defined security entity within the kernel. LSM should not be used just because it has a few hooks in the right place for your code. - James -- James Morris - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/