Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261580AbVEUNoN (ORCPT ); Sat, 21 May 2005 09:44:13 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261427AbVEUNoN (ORCPT ); Sat, 21 May 2005 09:44:13 -0400 Received: from mail.shareable.org ([81.29.64.88]:16090 "EHLO mail.shareable.org") by vger.kernel.org with ESMTP id S261420AbVEUNoI (ORCPT ); Sat, 21 May 2005 09:44:08 -0400 Date: Sat, 21 May 2005 14:43:58 +0100 From: Jamie Lokier To: Ram Cc: Miklos Szeredi , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Andrew Morton , viro@parcelfarce.linux.theplanet.co.uk Subject: Re: [RFC][PATCH] rbind across namespaces Message-ID: <20050521134358.GA4274@mail.shareable.org> References: <1116627099.4397.43.camel@localhost> <1116660380.4397.66.camel@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1116660380.4397.66.camel@localhost> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 797 Lines: 21 Ram wrote: > > Also why check current->namespace? It doesn't hurt to do > > get_namespace() even if it's not strictly needed. And it would > > simplify the code. > > however get_namespace() will chew up some extra cycles > sometimes unnecessarily. I did incorporate your comment and > got much simpler code. Checking current->namespace also chews up extra cycles, sometimes unnecessarily, but the cycles are negligable in both cases. Because they're negligable, the most important thing is to avoid unnecessary complications in the code. -- Jamie - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/