Date: Sat, 21 May 2005 22:21:51 -0700
From: randy_dunlap <rdunlap@xenotime.net>
To: Patrick Plattes <patrick@erdbeere.net>
Cc: linux-kernel@vger.kernel.org, manfred@colorfullife.com
Subject: Re: semaphore understanding: sys_semtimedop()
Message-Id: <20050521222151.15bb0eb4.rdunlap@xenotime.net>
In-Reply-To: <20050516201704.GA9836@erdbeere.net>
References: <20050516201704.GA9836@erdbeere.net>
Organization: YPO4
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1519
Lines: 46

On Mon, 16 May 2005 22:17:04 +0200 Patrick Plattes wrote:

| Hello,
| 
| i have a question about this little code snippet, found in
| sys_semtimedop() (ipc/sem.c):
| 
|         for (sop = sops; sop < sops + nsops; sop++) {
|                 if (sop->sem_num >= max)
|                         max = sop->sem_num;
|                 if (sop->sem_flg & SEM_UNDO)
|                         undos++;
|                 if (sop->sem_op < 0)
|                         decrease = 1;
|                 if (sop->sem_op > 0)
|                         alter = 1;
|         }
|         alter |= decrease;
| 
| The variable decrease will never be used again in this 
| function, so why this intricate code? Isn't this much easier and works
| also:
| 
|         for (sop = sops; sop < sops + nsops; sop++) {
|                 if (sop->sem_num >= max)
|                         max = sop->sem_num;
|                 if (sop->sem_flg & SEM_UNDO)
|                         undos++;
|                 if (sop->sem_op != 0)
|                         alter = 1;
|         }
| 
| Maybe i'm totally wrong, so please correct me and don't shoot me up,
| 'cause i'm not a os developer.

Looks like a reasonable and correct optimization to me.

Let's see what Manfred thinks or has to say...

---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/