Subject: RE: [patch 2.6.12-rc3] dell_rbu: Resubmitting patch for new Dell
	BIOS update driver
From: Marcel Holtmann <marcel@holtmann.org>
To: Abhay_Salunke@Dell.com
Cc: greg@kroah.com, linux-kernel@vger.kernel.org, akpm@osdl.org,
       Matt_Domsch@Dell.com
In-Reply-To: <367215741E167A4CA813C8F12CE0143B3ED388@ausx2kmpc115.aus.amer.dell.com>
References: <367215741E167A4CA813C8F12CE0143B3ED388@ausx2kmpc115.aus.amer.dell.com>
Content-Type: text/plain
Date: Mon, 23 May 2005 16:59:38 +0200
Message-Id: <1116860378.30044.92.camel@pegasus>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1011
Lines: 31

Hi Abhay,

> > Also, what's wrong with using the existing firmware interface in the
> > kernel?
> request_firmware requires the $FIRMWARE env to be populated with the
> firmware image name or the firmware image name needs to be hardcoded
> within  the call to request_firmware.

the latter one. Don't mess with the $FIRMWARE env, because this comes
from the kernel hotplug call.

> Since the user is free to change
> the BIOS update image at will, it may not be possible if we use
> $FIRMWARE also I am not sure if this env variable might be conflicting
> to some other driver.

I am not quite sure what's the problem here. Tell the kernel what
firmware image to request. Something like

	echo "firmware-filename" > /sys/firmware/dell_rbu/download

Regards

Marcel


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/