Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261239AbVEWXV5 (ORCPT ); Mon, 23 May 2005 19:21:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261212AbVEWXVU (ORCPT ); Mon, 23 May 2005 19:21:20 -0400 Received: from fire.osdl.org ([65.172.181.4]:35715 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S261171AbVEWXUC (ORCPT ); Mon, 23 May 2005 19:20:02 -0400 Date: Mon, 23 May 2005 16:19:20 -0700 From: Chris Wright To: linux-kernel@vger.kernel.org, stable@kernel.org Cc: Justin Forbes , Zwane Mwaikambo , "Theodore Ts'o" , Randy Dunlap , Chuck Wolber , torvalds@osdl.org, akpm@osdl.org, alan@lxorguk.ukuu.org.uk, bdschuym@pandora.be, herbert@gondor.apana.org.au, mailinglists@unix-scripts.com Subject: [patch 03/16] [EBTABLES]: Fix smp race. Message-ID: <20050523231920.GO27549@shell0.pdx.osdl.net> References: <20050523231529.GL27549@shell0.pdx.osdl.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050523231529.GL27549@shell0.pdx.osdl.net> User-Agent: Mutt/1.5.6i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1197 Lines: 32 The patch below fixes an smp race that happens on such systems under heavy load. This bug was reported and solved by Steve Herrell Signed-off-by: Bart De Schuymer Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/bridge/netfilter/ebtables.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletion(-) --- linux-2.6.11.10.orig/net/bridge/netfilter/ebtables.c 2005-05-20 09:36:00.942030616 -0700 +++ linux-2.6.11.10/net/bridge/netfilter/ebtables.c 2005-05-20 09:36:18.350384144 -0700 @@ -179,9 +179,10 @@ struct ebt_chainstack *cs; struct ebt_entries *chaininfo; char *base; - struct ebt_table_info *private = table->private; + struct ebt_table_info *private; read_lock_bh(&table->lock); + private = table->private; cb_base = COUNTER_BASE(private->counters, private->nentries, smp_processor_id()); if (private->chainstack) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/