Date: Tue, 24 May 2005 00:50:53 +0100
From: Al Viro <viro@parcelfarce.linux.theplanet.co.uk>
To: Chris Wright <chrisw@osdl.org>
Cc: linux-kernel@vger.kernel.org, stable@kernel.org,
       Justin Forbes <jmforbes@linuxtx.org>,
       Zwane Mwaikambo <zwane@arm.linux.org.uk>,
       "Theodore Ts'o" <tytso@mit.edu>, Randy Dunlap <rdunlap@xenotime.net>,
       Chuck Wolber <chuckw@quantumlinux.com>, torvalds@osdl.org,
       akpm@osdl.org, alan@lxorguk.ukuu.org.uk, p2@mind.be,
       vandrove@vc.cvut.cz, dsd@gentoo.org
Subject: Re: [patch 06/16] Fix matroxfb on big-endian hardware
Message-ID: <20050523235052.GX29811@parcelfarce.linux.theplanet.co.uk>
References: <20050523231529.GL27549@shell0.pdx.osdl.net> <20050523232207.GR27549@shell0.pdx.osdl.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20050523232207.GR27549@shell0.pdx.osdl.net>
User-Agent: Mutt/1.4.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 792
Lines: 25

On Mon, May 23, 2005 at 04:22:07PM -0700, Chris Wright wrote:
> -				mga_writel(mmio, 0, *chardata);
> +#if defined(__BIG_ENDIAN)
> +				fb_writel((*chardata) << 24, mmio.vaddr);
> +#else
> +				fb_writel(*chardata, mmio.vaddr);
> +#endif

So basically you are passing it cpu_to_le32(*chardata)?

> +#if defined(__BIG_ENDIAN)
> +				fb_writel((*(u_int16_t*)chardata) << 16, mmio.vaddr);
> +#else
> +				fb_writel(*(u_int16_t*)chardata, mmio.vaddr);
> +#endif

*yuck*

cpu_to_le32(le16_to_cpu(*(__le16 *)chardata)?  Is that what you are doing
here?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/