Date: Mon, 23 May 2005 17:29:23 -0700
From: Andrew Morton <akpm@osdl.org>
To: george@mvista.com
Cc: oleg@tv-sign.ru, linux-kernel@vger.kernel.org
Subject: Re: [PATCH rc4-mm2 2/2] posix-timers: use try_to_del_timer_sync()
Message-Id: <20050523172923.26068053.akpm@osdl.org>
In-Reply-To: <42926F83.9050608@mvista.com>
References: <42909DC2.7922E05D@tv-sign.ru>
	<42926F83.9050608@mvista.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 946
Lines: 21

George Anzinger <george@mvista.com> wrote:
>
> Oleg Nesterov wrote:
> > sys_timer_settime/sys_timer_delete needs to delete k_itimer->real.timer
> > synchronously while holding ->it_lock, which is also locked in posix_timer_fn.
> > 
> > This patch removes timer_active/set_timer_inactive which plays with
> > timer_list's internals in favour of using try_to_del_timer_sync(),
> > which was introduced in the previous patch.
> 
> Is there a particular reason for this, like it does not work, for example, or 
> are you just trying to clean up code?

The posix-timers code is poking about in the internals of the timer_list
implementation.  It shouldn't, and finding some way to fix that up is
desirable.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/