Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261286AbVEXDvg (ORCPT ); Mon, 23 May 2005 23:51:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261283AbVEXDve (ORCPT ); Mon, 23 May 2005 23:51:34 -0400 Received: from arnor.apana.org.au ([203.14.152.115]:61963 "EHLO arnor.apana.org.au") by vger.kernel.org with ESMTP id S261265AbVEXDvL (ORCPT ); Mon, 23 May 2005 23:51:11 -0400 Date: Tue, 24 May 2005 13:50:56 +1000 To: James Morris Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, davem@davemloft.net Subject: Re: [CRYPTO]: Only reschedule if !in_atomic() Message-ID: <20050524035056.GB29699@gondor.apana.org.au> References: <20050524024318.GB29242@gondor.apana.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.9i From: Herbert Xu Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1118 Lines: 28 On Mon, May 23, 2005 at 11:20:26PM -0400, James Morris wrote: > > a) remove the scheudling point and see if anyone complains > b) if so, add a flag OK. I think we should go with the flag though since it could also be used for memory allocation. I've just added some code which allocates a scratch space for unaligned input to the VIA Padlock (IPv4 ESP traffic is normally unaligned due to the 20-byte IP header). It could use this flag to determine whether it should do GFP_KERNEL or GFP_ATOMIC. Actually, has anyone considered using a 4-byte IP option padding? It's legal per RFC-791 but it'd be interesting to know how well it works in the field. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/