Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261292AbVEYICw (ORCPT ); Wed, 25 May 2005 04:02:52 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261336AbVEYICw (ORCPT ); Wed, 25 May 2005 04:02:52 -0400 Received: from siaag1ab.compuserve.com ([149.174.40.4]:44284 "EHLO siaag1ab.compuserve.com") by vger.kernel.org with ESMTP id S261292AbVEYICq (ORCPT ); Wed, 25 May 2005 04:02:46 -0400 Date: Wed, 25 May 2005 03:57:14 -0400 From: Chuck Ebbert <76306.1226@compuserve.com> Subject: Re: [patch 07/16] ide-disk: Fix LBA8 DMA To: Chris Wright Cc: linux-kernel , linux-stable , Justin Forbes , Zwane Mwaikambo , "Theodore Ts'o" , Randy Dunlap , Chuck Wolber , Linus Torvalds , Andrew Morton , Alan Cox , Bartlomiej Zolnierkiewicz , Daniel Drake Message-ID: <200505250400_MC3-1-9FB4-BDB5@compuserve.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 960 Lines: 33 On Mon, 23 May 2005 at 16:24:14 -0700, Chris Wright wrote: > --- linux-2.6.11.10.orig/drivers/ide/ide-disk.c 2005-05-16 10:50:31.000000000 -0700 > +++ linux-2.6.11.10/drivers/ide/ide-disk.c 2005-05-20 09:36:31.933319224 -0700 > @@ -133,6 +133,8 @@ > if (hwif->no_lba48_dma && lba48 && dma) { > if (block + rq->nr_sectors > 1ULL << 28) ^ Maybe I'm an idiot, but shouldn't that be ">="? Either that or it should be comparing to (1ULL < 28 - 1)? > dma = 0; > + else > + lba48 = 0; ^^^^^^^^^^^^^^^^^^^^^^^ Spaces instead of tabs? > } > > if (!dma) { -- Chuck - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/