Date: Wed, 25 May 2005 18:36:07 +0530
From: Vivek Goyal <vgoyal@in.ibm.com>
To: Alexander Nyberg <alexn@telia.com>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org,
       fastboot@lists.osdl.org
Subject: Re: [Fastboot] [1/2] kdump: Use real pt_regs from exception
Message-ID: <20050525130607.GB3658@in.ibm.com>
Reply-To: vgoyal@in.ibm.com
References: <1116103798.6153.30.camel@localhost.localdomain> <20050518123500.GA3657@in.ibm.com> <1116427862.22324.5.camel@localhost.localdomain> <20050525020749.1ad56a80.akpm@osdl.org> <1117023296.877.11.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1117023296.877.11.camel@localhost.localdomain>
User-Agent: Mutt/1.4.2.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1166
Lines: 35

On Wed, May 25, 2005 at 02:14:56PM +0200, Alexander Nyberg wrote:
> ons 2005-05-25 klockan 02:07 -0700 skrev Andrew Morton:
> > Alexander Nyberg <alexn@telia.com> wrote:
> > >
> > > -extern void machine_crash_shutdown(void);
> > >  +extern void machine_crash_shutdown(struct pt_regs *);
> > 
> > That'll break x86_64, ppc, ppc64 and s/390.
> 
> I'm such an idiot.
> 
> Make sure all arches take pt_regs * as argument to
> machine_crash_shutdown(). (now cross-compiled on above arches except
> s/390).
> 

Alexander, I face following warning if I build my kernel without HIGHMEM
support. Fianally linker fails in the end.

CC      kernel/kexec.o
kernel/kexec.c: In function `kexec_should_crash':
kernel/kexec.c:37: warning: implicit declaration of function `in_interrupt'

If I include HIGHMEM support, it compiles fine.

You might have to include include/linux/hardirq.h in kexec.c to 
resolve the problem.

Thanks
Vivek 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/