Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 8BIT
Subject: RE: [patch] Kprobes ia64 qp fix
Date: Thu, 26 May 2005 11:23:44 -0700
Message-ID: <032EB457B9DBC540BFB1B7B519C78B0E073AE2CC@orsmsx404.amr.corp.intel.com>
Thread-Topic: [patch] Kprobes ia64 qp fix
thread-index: AcViH2GXn4xndsU6SbmV0M3J6vyuqQAAFO0w
From: "Lynch, Rusty" <rusty.lynch@intel.com>
To: <davidm@hpl.hp.com>
Cc: <akpm@osdl.org>, "Keshavamurthy, Anil S" <anil.s.keshavamurthy@intel.com>,
       <linux-kernel@vger.kernel.org>, <linux-ia64@vger.kernel.org>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1167
Lines: 35

>>>>>> On Thu, 26 May 2005 10:51:45 -0700, Rusty Lynch
><rusty.lynch@intel.com> said:
>
>  Rusty> The following patch is for the 2.6.12-rc5-mm1 + my previous
>  Rusty> "Kprobes ia64 cleanup" patch that fixes a bug where a kprobe
still
>  Rusty> fires when the instruction is predicated off.  So given the
p6=0,
>  Rusty> and we have an instruction like:
>
>  Rusty> (p6) move loc1=0
>
>  Rusty> we should not be triggering the kprobe.  This is handled by
>  Rusty> carrying over the qp section of the original instruction into
>  Rusty> the break instruction.
>
>What about:
>
>	(p6) cmp.eq.unc p9,p10=rX,rY
>
>would the code handle that right?  Similary, you may want to check for
>the correct handling of instructions that cannot be predicated (such
>as "cover").
>
>	--david

Thanks, I need to look into this one.  Let me update my test to cover
both of these cases and then take another look at our logic.

    --rusty
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/