Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261269AbVE0B1F (ORCPT ); Thu, 26 May 2005 21:27:05 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261410AbVE0BX2 (ORCPT ); Thu, 26 May 2005 21:23:28 -0400 Received: from mail.dvmed.net ([216.237.124.58]:11996 "EHLO mail.dvmed.net") by vger.kernel.org with ESMTP id S261269AbVE0BVL (ORCPT ); Thu, 26 May 2005 21:21:11 -0400 Message-ID: <42967601.7080003@pobox.com> Date: Thu, 26 May 2005 21:21:05 -0400 From: Jeff Garzik User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.6) Gecko/20050328 Fedora/1.7.6-1.2.5 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Mark Lord CC: "linux-ide@vger.kernel.org" , Linux Kernel , Jens Axboe , Al Viro Subject: Re: [PATCH] libata: fix use-after-free during driver unload/unplug References: <42962379.5000206@pobox.com> <42964099.6000207@pobox.com> In-Reply-To: <42964099.6000207@pobox.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1233 Lines: 36 Mark Lord wrote: > Hi Jeff! > > Jeff Garzik wrote: > >> >> * add ->host_stop_prewalk() hook, use it in sata_qstor.c (hi Mark). >> sata_qstor appears to require the host-stop-before-port-stop ordering >> that existed prior to applying the attached patch. > > > Mmm.. I'm a little bit rusty here, but I don't think qstor > cares about the order, so long as ports are marked with > ATA_FLAG_PORT_DISABLED before invoking port_stop(). > > I've tried to allow disabling/enabling individual ports > on-the-fly as needed, even though it never really happens > in practice. So host_stop() kills the whole chip, whereas > port_stop() I took to mean just one of the four SATA ports. qstor's ->host_stop() disables global interrupts, and I didn't know if you really wanted to do that prior to ->port_stop(). I would much prefer to eliminate the ->host_stop_prewalk() hook, and simply call ->host_stop after all ->port_stop() calls complete, if qstor doesn't need the pre-walk. Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/