Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261964AbVE0HyC (ORCPT ); Fri, 27 May 2005 03:54:02 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261967AbVE0Hxy (ORCPT ); Fri, 27 May 2005 03:53:54 -0400 Received: from mail.dvmed.net ([216.237.124.58]:53469 "EHLO mail.dvmed.net") by vger.kernel.org with ESMTP id S261964AbVE0HvQ (ORCPT ); Fri, 27 May 2005 03:51:16 -0400 Message-ID: <4296D16F.9030805@pobox.com> Date: Fri, 27 May 2005 03:51:11 -0400 From: Jeff Garzik User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.6) Gecko/20050328 Fedora/1.7.6-1.2.5 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Jens Axboe CC: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: Playing with SATA NCQ References: <20050526140058.GR1419@suse.de> <4295F87B.9070106@pobox.com> <20050527072046.GN1435@suse.de> <4296CC5C.5000807@pobox.com> <20050527073307.GP1435@suse.de> In-Reply-To: <20050527073307.GP1435@suse.de> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 819 Lines: 27 Jens Axboe wrote: > On Fri, May 27 2005, Jeff Garzik wrote: > >>Jens Axboe wrote: >> >>>I double checked this. If you agree to move the setting of QCFLAG_ACTIVE >>>_after_ successful ap->ops->qc_issue(qc) and clear it _after_ >>>__ata_qc_complete(qc) then I can just use that bit and kill >>>ATA_QCFLAG_ACCOUNT. >>> >>>What do you think? >> >>Fine with me. >> >>Keep in mind that the attached patch was applied recently... > > > Yeah, the two hunks from the ncq patch would look like this then. Ok? ACK (modulo my distaste for 'depth' and 'ncq_depth', of course... :)) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/