Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262421AbVE0Jpt (ORCPT ); Fri, 27 May 2005 05:45:49 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262409AbVE0JoQ (ORCPT ); Fri, 27 May 2005 05:44:16 -0400 Received: from ns1.suse.de ([195.135.220.2]:25513 "EHLO mx1.suse.de") by vger.kernel.org with ESMTP id S262420AbVE0JlJ (ORCPT ); Fri, 27 May 2005 05:41:09 -0400 Date: Fri, 27 May 2005 11:41:05 +0200 Message-ID: From: Takashi Iwai To: "J.A. Magallon" Cc: linux-kernel@vger.kernel.org Subject: Re: 2.6.12-rc3-mm3: ALSA broken ? In-Reply-To: <1117151518l.7637l.0l@werewolf.able.es> References: <20050504221057.1e02a402.akpm@osdl.org> <1115510869l.7472l.0l@werewolf.able.es> <1115594680l.7540l.0l@werewolf.able.es> <1115936836l.8448l.1l@werewolf.able.es> <1116331359l.7364l.0l@werewolf.able.es> <1116369585l.8840l.0l@werewolf.able.es> <1117151518l.7637l.0l@werewolf.able.es> User-Agent: Wanderlust/2.10.1 (Watching The Wheels) SEMI/1.14.5 (Awara-Onsen) FLIM/1.14.5 (Demachiyanagi) APEL/10.6 MULE XEmacs/21.4 (patch 15) (Security Through Obscurity) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen") Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3056 Lines: 92 At Thu, 26 May 2005 23:51:58 +0000, J.A. Magallon wrote: > > > On 05.18, Takashi Iwai wrote: > > At Tue, 17 May 2005 22:39:45 +0000, > > J.A. Magallon wrote: > > > > > > > > > On 05.17, Takashi Iwai wrote: > > > ... > > > > > > > > > > Example: go into 4ch mode. Check this control. Then switch to 6ch mode. > > > > > The Center jack has no sound (it should, shouldn't ?). Check it and voil?. > > > > > It looks that the logic in the channel selection needs to set this flag also... > > > > > > > > Yep, you're right. Try the patch below. > > > > > > > > > > > > > > Thanks, this patch worked. When in 6ch mode, the boolen flag we talk about > > > still controls if the line jack is input or output. In 4ch mode, it is always > > > input. If i chech it, switching to 6ch does not toggle it. They are > > > independent controls. > > > > > > Anyways. I can't get rid of the flag. It is initialized to on by default. > > > Isn't strange to have two ways of controlling this ? > > > > > Yehaaa, I got it... > There was a bug in your last patch. > This: > > + snd_ac97_update_bits(ac97, AC97_AD_SERIAL_CFG, 9 << 11, > + is_shared_micin(ac97) ? 0 : 9 << 11); > > should be > > + snd_ac97_update_bits(ac97, AC97_AD_SERIAL_CFG, 1 << 9, > + is_shared_micin(ac97) ? 0 : 1 << 9); > > Whit this, I can control the output just with the 2/4/6 ch mode, and get rid > of the 'Center as mic' flag... Oh yeah, thanks. Fixed on ALSA tree, too. > btw, why the hell don't you use something as stupid as > > #define bit(n) (1<<(n)) > > ??? I don't think this always improves the readability. > A side note. In the process of solving all this, I tried to generate a patch > for 1.0.9rc4a against -mm. I noticed some things: > - Your code reverts some in-kernel changes related to > if (ptr) > kfree(ptr) > The if is killed in mainline, as kfree accepts null pointers. Could you point which places? > - When linking I got: > if [ -r System.map -a -x /sbin/depmod ]; then /sbin/depmod -ae -F System.map > 2.6.11-jam20; fi > WARNING: /lib/modules/2.6.11-jam20/kernel/sound/soundcore.ko needs unknown > symbol class_simple_device_add > WARNING: /lib/modules/2.6.11-jam20/kernel/sound/soundcore.ko needs unknown > symbol class_simple_destroy > WARNING: /lib/modules/2.6.11-jam20/kernel/sound/soundcore.ko needs unknown > symbol class_simple_device_remove > WARNING: /lib/modules/2.6.11-jam20/kernel/sound/soundcore.ko needs unknown > symbol class_simple_create > WARNING: /lib/modules/2.6.11-jam20/kernel/sound/core/snd.ko needs unknown > symbol class_simple_device_add > WARNING: /lib/modules/2.6.11-jam20/kernel/sound/core/snd.ko needs unknown > symbol class_simple_device_remove This doesn't come from ALSA 1.0.9rc4. The alsa-driver tree doesn't compile this module. Takashi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/