Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262526AbVE0R0v (ORCPT ); Fri, 27 May 2005 13:26:51 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262525AbVE0R0v (ORCPT ); Fri, 27 May 2005 13:26:51 -0400 Received: from fire.osdl.org ([65.172.181.4]:4529 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S262523AbVE0R0r (ORCPT ); Fri, 27 May 2005 13:26:47 -0400 Date: Fri, 27 May 2005 10:28:44 -0700 (PDT) From: Linus Torvalds To: Sean cc: Jaroslav Kysela , LKML , Andrew Morton , Git Mailing List Subject: Re: ALSA official git repository In-Reply-To: <3516.10.10.10.24.1117213207.squirrel@linux1> Message-ID: References: <3516.10.10.10.24.1117213207.squirrel@linux1> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1135 Lines: 33 On Fri, 27 May 2005, Sean wrote: > > > > Now, arguably gitweb should ignore whitespace at the beginning, but > > equally arguably your commits shouldn't have them either... > > Perhaps git should enforce this? Patch attached. > > Remove leading empty lines from commit messages. > > Signed-off-by: Sean Estabrooks I'm not sure. The thing is, right now git allows binary commit messages if somebody really wants to. Now, a lot of the _tools_ end up only printing up to the first '\0' or something, but in general, maybe somebody actually wants to embed his own strange stuff in there (eg use encryption but still use standard git tools). Which makes me worry. So I _do_ do whitespace cleanup in my "apply email patches" scripts, but I'm not sure whether the core should care about the data that people feed it, even for commit messages. Opinions? Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/