Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262522AbVE1JGC (ORCPT ); Sat, 28 May 2005 05:06:02 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262512AbVE1JGC (ORCPT ); Sat, 28 May 2005 05:06:02 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:33415 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S262510AbVE1JFz (ORCPT ); Sat, 28 May 2005 05:05:55 -0400 Date: Sat, 28 May 2005 10:05:41 +0100 From: Christoph Hellwig To: Badari Pulavarty Cc: Carsten Otte , suparna@in.ibm.com, Linux Kernel Mailing List , linux-fsdevel , schwidefsky@de.ibm.com, Andrew Morton Subject: Re: [RFC/PATCH 2/4] fs/mm: execute in place (3rd version) Message-ID: <20050528090541.GA19153@infradead.org> Mail-Followup-To: Christoph Hellwig , Badari Pulavarty , Carsten Otte , suparna@in.ibm.com, Linux Kernel Mailing List , linux-fsdevel , schwidefsky@de.ibm.com, Andrew Morton References: <1116866094.12153.12.camel@cotte.boeblingen.de.ibm.com> <1116869420.12153.32.camel@cotte.boeblingen.de.ibm.com> <20050524093029.GA4390@in.ibm.com> <42930B64.2060105@freenet.de> <20050524133211.GA4896@in.ibm.com> <42933B7A.3060206@freenet.de> <1117043475.26913.1540.camel@dyn318077bld.beaverton.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1117043475.26913.1540.camel@dyn318077bld.beaverton.ibm.com> User-Agent: Mutt/1.4.1i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1248 Lines: 30 On Wed, May 25, 2005 at 10:51:17AM -0700, Badari Pulavarty wrote: > This is my crude version of the cleanup patch to reduce the > duplication of code. > > Basically, I added __generic_file_aio_read_internal() and > __generic_file_aio_write_nolock_internal() to take a read/write > handlers instead of defaulting to do_generic_file_read() or > generic_file_buffered_write(). > > This way I was able to reduce 129 lines of your code. > This patch is on top of your current set and I haven't even > tried compiling it. Needs cleanup. > > > BTW, function & variable names are too long and/or ugly & doesn't > make sense - need fixing. > > Christoph/Suparna/Andrew, Comments ? I don't like this patch a lot. It adds another indirection to the code, and still leaves the O_DIRECT branches in the XIP path that don't make any sense. If you're looking for a way to consolidate duplicated code some abtraction for the iovec verification makes most sense, as there's very little other code duplicated. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/