Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261184AbVE1VuZ (ORCPT ); Sat, 28 May 2005 17:50:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261185AbVE1VuZ (ORCPT ); Sat, 28 May 2005 17:50:25 -0400 Received: from mx1.redhat.com ([66.187.233.31]:30682 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S261184AbVE1VuT (ORCPT ); Sat, 28 May 2005 17:50:19 -0400 Date: Sat, 28 May 2005 17:50:05 -0400 From: Dave Jones To: Geert Uytterhoeven Cc: Andrew Morton , David Airlie , Linux Kernel Development , dri-devel@lists.sourceforge.net Subject: Re: [PATCH] DRM depends on ??? Message-ID: <20050528215005.GA5990@redhat.com> Mail-Followup-To: Dave Jones , Geert Uytterhoeven , Andrew Morton , David Airlie , Linux Kernel Development , dri-devel@lists.sourceforge.net References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1098 Lines: 33 On Sat, May 28, 2005 at 11:39:00PM +0200, Geert Uytterhoeven wrote: > > DRM depending on `AGP=n' is driving me crazy! How to make CONFIG_DRM not > eligible for selection on platforms that do not have AGP? > > Since many of the core DRM files depend on PCI, add a dependency on PCI, > to minimize the damage. > > Signed-off-by: Geert Uytterhoeven > > --- linux-2.6.12-rc5/drivers/char/drm/Kconfig 2005-05-25 19:37:53.000000000 +0200 > +++ linux-m68k-2.6.12-rc5/drivers/char/drm/Kconfig 2005-04-05 10:12:41.000000000 +0200 > @@ -6,7 +6,7 @@ > # > config DRM > tristate "Direct Rendering Manager (XFree86 4.1.0 and higher DRI support)" > - depends on AGP || AGP=n > + depends on (AGP || AGP=n) && PCI The whole dependancy seems like nonsense to me. I think depends on PCI is a lot more sensible. Dave - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/