Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261502AbVE3Cxs (ORCPT ); Sun, 29 May 2005 22:53:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261503AbVE3Cxs (ORCPT ); Sun, 29 May 2005 22:53:48 -0400 Received: from fire.osdl.org ([65.172.181.4]:63360 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S261502AbVE3Cxq (ORCPT ); Sun, 29 May 2005 22:53:46 -0400 Date: Sun, 29 May 2005 19:52:45 -0700 From: Andrew Morton To: "David S. Miller" Cc: phdm@macqel.be, linux-kernel@vger.kernel.org, uclinux-dev@uclinux.org Subject: Re: PATCH : ppp + big-endian = kernel crash Message-Id: <20050529195245.33f36253.akpm@osdl.org> In-Reply-To: <20050529.145509.82051753.davem@davemloft.net> References: <20050529.135257.98862077.davem@davemloft.net> <200505292138.j4TLcrJ28536@mail.macqel.be> <20050529.145509.82051753.davem@davemloft.net> X-Mailer: Sylpheed version 1.0.4 (GTK+ 1.2.10; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1322 Lines: 31 "David S. Miller" wrote: > > From: "Philippe De Muyter" > Date: Sun, 29 May 2005 23:38:53 +0200 (CEST) > > > Do you mean that ip_rcv may not assume that packets are properly aligned ? > > > > And some non-mmu m68k (Coldfires) do not provide enough information in > > exception frames to restart instructions on an address error in the general > > case. > > So many variants of tunneling and protocol encapsulation can result in > unaligned packet headers, and as a result platforms really must > provide proper unaligned memory access handling in kernel mode in > order to use the networking fully. As Philippe mentioned, old 68k's simply cannot do this. > All these patches to PPP and friends are merely papering over the > larger problem. It's not a thing we want to do in the general case, sure. But it's reasonable to identify those bits of net code which the nommu people care about and look to see if there's some sane workaround to get them going. Otherwise, things like PPP will simply unavailable to some architectures... - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/