Subject: Re: 2.6.12-rc5-mm1: drivers/usb/atm/speedtch.c: gcc 2.95 compile
	error
From: Duncan Sands <baldrick@free.fr>
To: Andrew Morton <akpm@osdl.org>
Cc: bunk@stusta.de, linux-kernel@vger.kernel.org, gregkh@suse.de
In-Reply-To: <20050530010456.242b810e.akpm@osdl.org>
References: <20050525134933.5c22234a.akpm@osdl.org>
	 <20050529151231.GE10441@stusta.de>
	 <1117439106.9515.31.camel@localhost.localdomain>
	 <20050530010456.242b810e.akpm@osdl.org>
Content-Type: text/plain
Date: Mon, 30 May 2005 10:16:01 +0200
Message-Id: <1117440961.9515.40.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 833
Lines: 26

> > Hi Adrian, it looks like gcc 2.95 doesn't like this kind of macro
> > 
> >  #define atm_info(instance, format, arg...)	\
> >  	atm_printk(KERN_INFO, instance , format , ## arg)
> > 
> >  being called with only two arguments.  I don't know what
> >  the best fix is, but this does the trick:
> 
> Nope.  There's a bug in gcc-2.95.x macro expansion, and here it bites us in
> atm_printk():
> 
> printk(level "ATM dev %d: " format , (instance)->atm_dev->number, ## arg)
> 
> the workaround is to add a space before that final comma:

Yes, this fixes the problem.

Thanks a lot!

Duncan.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/