Date: Mon, 30 May 2005 18:55:22 +0200 (MEST)
From: "Michael Kerrisk" <michael.kerrisk@gmx.net>
To: Linus Torvalds <torvalds@osdl.org>
Cc: davem@davemloft.net, roland@redhat.com, akpm@osdl.org, mtk-lkml@gmx.net,
       linux-kernel@vger.kernel.org
MIME-Version: 1.0
References: <Pine.LNX.4.58.0505261617360.2307@ppc970.osdl.org>
Subject: Re: waitid() fails with EINVAL for SA_RESTART signals
Message-ID: <8295.1117472122@www60.gmx.net>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1211
Lines: 33

> On Thu, 26 May 2005, David S. Miller wrote:
> > 
> > > Other machines are subject to the same risk and should have a
> > > prevent_tail_call definition too.  The asm-i386/linkage.h version
> > > probably
> > > works fine for every machine.  It might as well be generic, I'd say.
> > 
> > Sparc, for one, doesn't need it.  We pass the pt_regs in via a pointer
> > to the trap level stack frame which won't be released by a tail-call
> > in C code.
> 
> x86 has largely tried to move in that direction too, ie a lot of the 
> asm-calls have been turned into FASTCALL() with %eax pointing to the 
> stack.
> 
> Roland, I applied the patch, but if there was some particular case that 
> triggered this, maybe it's worth trying to re-write that one.

Did I miss something.  Did this patch come through the 
list?  (I didn't see it.)

Cheers,

Michael

-- 
5 GB Mailbox, 50 FreeSMS http://www.gmx.net/de/go/promail
+++ GMX - die erste Adresse f?r Mail, Message, More +++
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/