Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261469AbVEaPiT (ORCPT ); Tue, 31 May 2005 11:38:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261913AbVEaPiT (ORCPT ); Tue, 31 May 2005 11:38:19 -0400 Received: from titan.genwebhost.com ([209.9.226.66]:16821 "EHLO titan.genwebhost.com") by vger.kernel.org with ESMTP id S261469AbVEaPiJ (ORCPT ); Tue, 31 May 2005 11:38:09 -0400 Date: Tue, 31 May 2005 08:37:59 -0700 From: randy_dunlap To: Roman Zippel Cc: viro@parcelfarce.linux.theplanet.co.uk, geert@linux-m68k.org, linux-kernel@vger.kernel.org, linux-m68k@vger.kernel.org Subject: Re: more thread_info patches Message-Id: <20050531083759.320ccb5a.rdunlap@xenotime.net> In-Reply-To: References: <42676B76.4010903@ppp0.net> <20050421161106.GY13052@parcelfarce.linux.theplanet.co.uk> <20050421173908.GZ13052@parcelfarce.linux.theplanet.co.uk> <20050530182511.434b0e97.rdunlap@xenotime.net> Organization: YPO4 X-Mailer: Sylpheed version 1.0.4 (GTK+ 1.2.10; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - titan.genwebhost.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [0 0] / [47 12] X-AntiAbuse: Sender Address Domain - xenotime.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1709 Lines: 45 On Tue, 31 May 2005 11:35:04 +0200 (CEST) Roman Zippel wrote: | Hi, | | On Mon, 30 May 2005, randy_dunlap wrote: | | > | Index: linux-2.6-mm/include/linux/sched.h | > | =================================================================== | > | --- linux-2.6-mm.orig/include/linux/sched.h 2005-05-31 01:19:01.636591190 +0200 | > | +++ linux-2.6-mm/include/linux/sched.h 2005-05-31 01:19:05.913856451 +0200 | > | @@ -617,6 +617,7 @@ struct mempolicy; | > | struct task_struct { | > | volatile long state; /* -1 unrunnable, 0 runnable, >0 stopped */ | > | struct thread_info *thread_info; | > | + void *stack; | > | > Any reason this is void * instead of being more strongly typed? | > Does the actual type vary? | | Yes, on m68k it actually doesn't point to the thread_info at all. | The point of these patches are to allow archs to put the thread_info | structure somewhere else. Archs with a thread register can keep | task_struct and thread_info together and directly accessable via the | thread register. Only because i386 has no usable thread register, doesn't | mean everyone else has to suffer. I see, thanks for the explanation. | > And a general comments about the 4 emails: | > they all have the same subject. :( | | I know and I did this intentionally, as these patches were not intended to | be applied, they are based on Al's patches and even these aren't in -mm | yet. I maybe should have added a [RFC]. I agree. Thanks, --- ~Randy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/