Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750742AbVIAIxV (ORCPT ); Thu, 1 Sep 2005 04:53:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750746AbVIAIxV (ORCPT ); Thu, 1 Sep 2005 04:53:21 -0400 Received: from isilmar.linta.de ([213.239.214.66]:42894 "EHLO linta.de") by vger.kernel.org with ESMTP id S1750742AbVIAIxV (ORCPT ); Thu, 1 Sep 2005 04:53:21 -0400 Date: Thu, 1 Sep 2005 10:53:19 +0200 From: Dominik Brodowski To: Marcelo Tosatti Cc: linux-ppc-embedded , linux-kernel@vger.kernel.org, Russell King , Dan Malek , Pantelis Antoniou Subject: Re: [PATCH] MPC8xx PCMCIA driver Message-ID: <20050901085319.GB6285@isilmar.linta.de> Mail-Followup-To: Dominik Brodowski , Marcelo Tosatti , linux-ppc-embedded , linux-kernel@vger.kernel.org, Russell King , Dan Malek , Pantelis Antoniou References: <20050830024840.GA5381@dmt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050830024840.GA5381@dmt.cnet> User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 659 Lines: 22 Hi, On Mon, Aug 29, 2005 at 11:48:40PM -0300, Marcelo Tosatti wrote: > Russell: The driver is using pccard_nonstatic_ops for card window > management, even though the driver its marked SS_STATIC_MAP (using > mem->static_map). This is obviously broken. Where does it fail if pccard_static_ops is used? > +typedef struct { > + u_int regbit; > + u_int eventbit; > +} event_table_t; No typedefs, please. Dominik - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/