Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 8BIT
Subject: RE: [Hotplug_sig] [patch 1/1] Hot plug CPU to support physical add of new processors (i386)
Date: Thu, 1 Sep 2005 10:48:20 -0500
Message-ID: <19D0D50E9B1D0A40A9F0323DBFA04ACCE04D0F@USRV-EXCH4.na.uis.unisys.com>
Thread-Topic: [Hotplug_sig] [patch 1/1] Hot plug CPU to support physical add of new processors (i386)
Thread-Index: AcWvCox3peJd7y3ISji7UxOaARVtxwAASq1g
From: "Protasevich, Natalie" <Natalie.Protasevich@UNISYS.com>
To: "Nathan Lynch" <nathanl@austin.ibm.com>
Cc: <shaohua.li@intel.com>, <akpm@osdl.org>, <zwane@arm.linux.org.uk>,
       <hotplug_sig@lists.osdl.org>, <linux-kernel@vger.kernel.org>,
       <lhcs-devel@lists.sourceforge.net>, <ak@suse.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1271
Lines: 40

> > +#ifdef CONFIG_HOTPLUG_CPU
> > +	if (cpu_online(cpu)) {
> > +#else
> >  	if (cpu_online(cpu) || !cpu_present(cpu)) {
> > +#endif
> >  		ret = -EINVAL;
> >  		goto out;
> >  	}
> 
> Why this change?  I think the cpu_present check is needed for 
> ppc64 since it has non-present cpus in sysfs.
> 

The new processor was never brought up, its bit is only set in
cpu_possible_map, but not in present map. 

        ... 
        if (boot_error) {
                /* Try to put things back the way they were before ...
*/
                unmap_cpu_to_logical_apicid(cpu);
                cpu_clear(cpu, cpu_callout_map); /* was set here
(do_boot_cpu()) */
                cpu_clear(cpu, cpu_initialized); /* was set by
cpu_init() */
                cpucount--;
        } else {
                x86_cpu_to_apicid[cpu] = apicid;
                cpu_set(cpu, cpu_present_map);  <=====================
        }
        ...
So if someone tries to boot a CPU up first time during runtime it always
fails this check.
Thanks,
--Natalie
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/