Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030327AbVIATtT (ORCPT ); Thu, 1 Sep 2005 15:49:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030328AbVIATtT (ORCPT ); Thu, 1 Sep 2005 15:49:19 -0400 Received: from mail.dvmed.net ([216.237.124.58]:3284 "EHLO mail.dvmed.net") by vger.kernel.org with ESMTP id S1030327AbVIATtS (ORCPT ); Thu, 1 Sep 2005 15:49:18 -0400 Message-ID: <43175B23.8040803@pobox.com> Date: Thu, 01 Sep 2005 15:48:51 -0400 From: Jeff Garzik User-Agent: Mozilla Thunderbird 1.0.6-1.1.fc4 (X11/20050720) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Christoph Hellwig CC: Brett Russ , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2.6.13] libata: Marvell SATA support (PIO mode) References: <20050830183625.BEE1520F4C@lns1058.lss.emc.com> <4314C604.4030208@pobox.com> <20050901142754.B93BF27137@lns1058.lss.emc.com> <20050901144038.GA25830@infradead.org> In-Reply-To: <20050901144038.GA25830@infradead.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 905 Lines: 31 Christoph Hellwig wrote: >>+#include >>+#include >>+#include >>+#include >>+#include >>+#include >>+#include >>+#include >>+#include >>+#include "scsi.h" > > > pleaese don't include "scsi.h" in new drivers. It will go away soon. > Use the headers and get rid of usage of obsolete constucts > in your driver. It stays until the rest of the libata drivers lose the include. After ATAPI support is done, I can stop 2.4.x support, and this and several other compat-isms will go away. Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/