Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161055AbVIBVna (ORCPT ); Fri, 2 Sep 2005 17:43:30 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1161059AbVIBVna (ORCPT ); Fri, 2 Sep 2005 17:43:30 -0400 Received: from smtp.osdl.org ([65.172.181.4]:49591 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S1161055AbVIBVn3 (ORCPT ); Fri, 2 Sep 2005 17:43:29 -0400 Date: Fri, 2 Sep 2005 14:45:52 -0700 From: Andrew Morton To: "J.A. Magallon" Cc: linux-kernel@vger.kernel.org Subject: Re: 2.6.13-mm1 Message-Id: <20050902144552.77c92d06.akpm@osdl.org> In-Reply-To: <1125676407l.6262l.0l@werewolf.able.es> References: <4317AD4D.6030001@reub.net> <1125626219l.6072l.0l@werewolf.able.es> <20050901190655.345914ba.akpm@osdl.org> <1125676407l.6262l.0l@werewolf.able.es> X-Mailer: Sylpheed version 1.0.0 (GTK+ 1.2.10; i386-vine-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2495 Lines: 71 "J.A. Magallon" wrote: > > > On 09.02, Andrew Morton wrote: > > "J.A. Magallon" wrote: > > > > > > > > > On 1/09/2005 10:58 a.m., Andrew Morton wrote: > > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.13/2.6.13-mm1/ > > > > > > > > - Included Alan's big tty layer buffering rewrite. This breaks the build on > > > > lots of more obscure character device drivers. Patches welcome (please cc > > > > Alan). > > > > > > > > > > I have problems with udev and latest -mm. > > > 2.6.13 boots fine, but 2.6.13-mm1 blocks when starting udev. > > > System is Mandriva Cooker. As cooker, things are changing fast (initscripts, > > > udev, etc), but the fact is that with the same setup, plain .13 boots > > > and -mm1 blocks. Udev is 068 version. > > > > > > Any idea about what can be the reason ? > > > > > > > There's some suspect locking in the /proc/devices seq_file conversion code. > > > > Could you revert convert-proc-devices-to-use-seq_file-interface-fix.patch > > then convert-proc-devices-to-use-seq_file-interface.patch? > > > > Still the same result, system bocks starting udev... > OK, thanks. Nothing from sysrq-t? Does the below help? --- devel/fs/sysfs/file.c~gregkh-driver-sysfs-strip_leading_trailing_whitespace-fix 2005-09-02 04:01:40.000000000 -0700 +++ devel-akpm/fs/sysfs/file.c 2005-09-02 04:05:02.000000000 -0700 @@ -202,13 +202,14 @@ fill_write_buffer(struct sysfs_buffer * * passing the buffer that we acquired in fill_write_buffer(). */ -static int -flush_write_buffer(struct dentry * dentry, struct sysfs_buffer * buffer, size_t count) +static int flush_write_buffer(struct dentry *dentry, + struct sysfs_buffer *buffer, size_t count_in) { struct attribute * attr = to_attr(dentry); struct kobject * kobj = to_kobj(dentry->d_parent); struct sysfs_ops * ops = buffer->ops; char *x; + size_t count = count_in; /* locate trailing white space */ while ((count > 0) && isspace(buffer->page[count - 1])) @@ -224,7 +225,8 @@ flush_write_buffer(struct dentry * dentr /* terminate the string */ x[count] = '\0'; - return ops->store(kobj, attr, x, count); + ops->store(kobj, attr, x, count); + return count_in; } _ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/