Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751342AbVICAPk (ORCPT ); Fri, 2 Sep 2005 20:15:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751242AbVICAPk (ORCPT ); Fri, 2 Sep 2005 20:15:40 -0400 Received: from relay02.mail-hub.dodo.com.au ([202.136.32.45]:7917 "EHLO relay02.mail-hub.dodo.com.au") by vger.kernel.org with ESMTP id S1751342AbVICAPj (ORCPT ); Fri, 2 Sep 2005 20:15:39 -0400 From: gcoady@gmail.com To: Andrew Morton Cc: "J.A. Magallon" , linux-kernel@vger.kernel.org Subject: Re: 2.6.13-mm1 Date: Sat, 03 Sep 2005 10:15:18 +1000 Organization: http://bugsplatter.mine.nu/ Message-ID: References: <4317AD4D.6030001@reub.net> <1125626219l.6072l.0l@werewolf.able.es> <20050901190655.345914ba.akpm@osdl.org> <1125676407l.6262l.0l@werewolf.able.es> <20050902144552.77c92d06.akpm@osdl.org> In-Reply-To: <20050902144552.77c92d06.akpm@osdl.org> X-Mailer: Forte Agent 2.0/32.652 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1669 Lines: 50 On Fri, 2 Sep 2005 14:45:52 -0700, Andrew Morton wrote: >"J.A. Magallon" wrote: >> [...] >> Still the same result, system bocks starting udev... >> > >OK, thanks. Nothing from sysrq-t? Does the below help? > >--- devel/fs/sysfs/file.c~gregkh-driver-sysfs-strip_leading_trailing_whitespace-fix 2005-09-02 04:01:40.000000000 -0700 >+++ devel-akpm/fs/sysfs/file.c 2005-09-02 04:05:02.000000000 -0700 >@@ -202,13 +202,14 @@ fill_write_buffer(struct sysfs_buffer * > * passing the buffer that we acquired in fill_write_buffer(). > */ > >-static int >-flush_write_buffer(struct dentry * dentry, struct sysfs_buffer * buffer, size_t count) >+static int flush_write_buffer(struct dentry *dentry, >+ struct sysfs_buffer *buffer, size_t count_in) > { > struct attribute * attr = to_attr(dentry); > struct kobject * kobj = to_kobj(dentry->d_parent); > struct sysfs_ops * ops = buffer->ops; > char *x; >+ size_t count = count_in; > > /* locate trailing white space */ > while ((count > 0) && isspace(buffer->page[count - 1])) >@@ -224,7 +225,8 @@ flush_write_buffer(struct dentry * dentr > /* terminate the string */ > x[count] = '\0'; > >- return ops->store(kobj, attr, x, count); >+ ops->store(kobj, attr, x, count); >+ return count_in; > } > > Hi Andrew, Patch above fixes problem with sysfs writes to adm9240 driver locking up console in last three -mm kernels. Grant. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/