Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750932AbVIDQd3 (ORCPT ); Sun, 4 Sep 2005 12:33:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750846AbVIDQd3 (ORCPT ); Sun, 4 Sep 2005 12:33:29 -0400 Received: from stat9.steeleye.com ([209.192.50.41]:60376 "EHLO hancock.sc.steeleye.com") by vger.kernel.org with ESMTP id S1750744AbVIDQd3 (ORCPT ); Sun, 4 Sep 2005 12:33:29 -0400 Subject: Re: 2.6.13-mm1: hangs during boot ... From: James Bottomley To: Reuben Farrelly Cc: Peter Williams , "Brown, Len" , Andrew Morton , Linux Kernel , SCSI Mailing List In-Reply-To: <4319A402.7030705@reub.net> References: <4319A402.7030705@reub.net> Content-Type: text/plain Date: Sun, 04 Sep 2005 11:32:05 -0500 Message-Id: <1125851525.4842.8.camel@mulgrave> Mime-Version: 1.0 X-Mailer: Evolution 2.0.4 (2.0.4-6) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2816 Lines: 82 On Sun, 2005-09-04 at 01:24 +1200, Reuben Farrelly wrote: > I am seeing it fill up my messages log as it is logging 1 or so messages each > minute. I've emailed the SCSI maintainer James Bottomley twice about it but > had no response either time. OK, can you try this ... it should confirm the theory if the messages go away. Thanks, James diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c --- a/drivers/scsi/scsi_lib.c +++ b/drivers/scsi/scsi_lib.c @@ -315,7 +315,7 @@ int scsi_execute(struct scsi_device *sde req->sense = sense; req->sense_len = 0; req->timeout = timeout; - req->flags |= flags | REQ_BLOCK_PC | REQ_SPECIAL; + req->flags |= flags | REQ_BLOCK_PC | REQ_SPECIAL | REQ_QUIET; /* * head injection *required* here otherwise quiesce won't work @@ -927,17 +927,20 @@ void scsi_io_completion(struct scsi_cmnd scsi_requeue_command(q, cmd); return; } - printk(KERN_INFO "Device %s not ready.\n", - req->rq_disk ? req->rq_disk->disk_name : ""); + if (!(req->flags & REQ_QUIET)) + dev_printk(KERN_INFO, + &cmd->device->sdev_gendev, + "Device not ready.\n"); cmd = scsi_end_request(cmd, 0, this_count, 1); return; case VOLUME_OVERFLOW: - printk(KERN_INFO "Volume overflow <%d %d %d %d> CDB: ", - cmd->device->host->host_no, - (int)cmd->device->channel, - (int)cmd->device->id, (int)cmd->device->lun); - __scsi_print_command(cmd->data_cmnd); - scsi_print_sense("", cmd); + if (!(req->flags & REQ_QUIET)) { + dev_printk(KERN_INFO, + &cmd->device->sdev_gendev, + "Volume overflow, CDB: "); + __scsi_print_command(cmd->data_cmnd); + scsi_print_sense("", cmd); + } cmd = scsi_end_request(cmd, 0, block_bytes, 1); return; default: @@ -954,15 +957,13 @@ void scsi_io_completion(struct scsi_cmnd return; } if (result) { - if (!(req->flags & REQ_SPECIAL)) - printk(KERN_INFO "SCSI error : <%d %d %d %d> return code " - "= 0x%x\n", cmd->device->host->host_no, - cmd->device->channel, - cmd->device->id, - cmd->device->lun, result); + if (!(req->flags & REQ_QUIET)) { + dev_printk(KERN_INFO, &cmd->device->sdev_gendev, + "SCSI error: return code = 0x%x\n", result); - if (driver_byte(result) & DRIVER_SENSE) - scsi_print_sense("", cmd); + if (driver_byte(result) & DRIVER_SENSE) + scsi_print_sense("", cmd); + } /* * Mark a single buffer as not uptodate. Queue the remainder. * We sometimes get this cruft in the event that a medium error - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/